Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #918

Merged
merged 3 commits into from
May 15, 2024
Merged

Fix CI #918

merged 3 commits into from
May 15, 2024

Conversation

benjeffery
Copy link
Member

No description provided.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.04%. Comparing base (92b3a37) to head (fd1ef7e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #918   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files           5        5           
  Lines        1767     1767           
  Branches      310      310           
=======================================
  Hits         1538     1538           
  Misses        140      140           
  Partials       89       89           
Flag Coverage Δ
C 87.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjeffery benjeffery force-pushed the fix-ci4 branch 2 times, most recently from 00a4e81 to 2a1ca1b Compare May 15, 2024 14:37
@benjeffery benjeffery changed the title Test CI Fix CI May 15, 2024
@benjeffery
Copy link
Member Author

Seems sgkit can't be installed on 3.12 due to cbgen:

Pinned packages:
  - python 3.12.*


Could not solve for environment specs
The following package could not be installed
└─ sgkit 0.8.0  is installable and it requires
   └─ cbgen with the potential options
      ├─ cbgen [1.0.0|1.0.1] would require
      │  └─ python >=3.7,<3.8.0a0 , which can be installed;
      ├─ cbgen [1.0.0|1.0.1] would require
      │  └─ python >=3.8,<3.9.0a0 , which can be installed;
      ├─ cbgen [1.0.0|1.0.1] would require
      │  └─ python >=3.9,<3.10.0a0 , which can be installed;
      └─ cbgen 1.0.1 would require
         └─ python >=3.10,<3.11.0a0 , which can be installed.

@jeromekelleher
Copy link
Member

Should probably open an issue on sgkit for cbgen thing.

@benjeffery
Copy link
Member Author

sgkit-dev/sgkit#1218

@benjeffery benjeffery marked this pull request as ready for review May 15, 2024 16:02
@benjeffery benjeffery merged commit ec3218d into tskit-dev:main May 15, 2024
13 checks passed
@benjeffery benjeffery deleted the fix-ci4 branch May 15, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants