Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASCII tree drawer does not support several options #55

Closed
jeromekelleher opened this issue Sep 12, 2017 · 3 comments
Closed

ASCII tree drawer does not support several options #55

jeromekelleher opened this issue Sep 12, 2017 · 3 comments

Comments

@jeromekelleher
Copy link
Member

There are several options on the tree.draw method that the ascii backend ignores. These should be updated and fixed.

At a minimum, we should update it to support drawing mutations.
@jeromekelleher jeromekelleher transferred this issue from tskit-dev/msprime Jan 11, 2019
@hyanwong
Copy link
Member

This also applies to the unicode drawer

@jeromekelleher
Copy link
Member Author

This will become irrelevant if we split the draw method into draw_text and draw_svg (and it part of the motivation for this split).

@brianzhang01
Copy link
Member

Makes sense to me to split the draw method

@jeromekelleher jeromekelleher mentioned this issue Jun 13, 2019
Closed
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Jun 21, 2019
@jeromekelleher
Improved argument handling in text trees.
5d8025c 
Closes tskit-dev#55 by raising a ValueError for any unsupported arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeromekelleher @hyanwong @brianzhang01