Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing #330

Merged
merged 2 commits into from
Aug 23, 2019
Merged

Fix testing #330

merged 2 commits into from
Aug 23, 2019

Conversation

petrelharp
Copy link
Contributor

I discovered some errors in the testing setup while mucking around with #328, and have pulled those out. These changes depend on #313; ignore those commits. I've run all the stats tests with p=1.0 to make sure things are good. Note that there were no errors with the actual implementations, only with two of our "naive" implementations.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #330 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   86.47%   86.47%   -0.01%     
==========================================
  Files          20       20              
  Lines       14035    14034       -1     
  Branches     2751     2751              
==========================================
- Hits        12137    12136       -1     
  Misses        979      979              
  Partials      919      919
Flag Coverage Δ
#c_tests 87.55% <100%> (-0.01%) ⬇️
#python_c_tests 90.3% <100%> (-0.01%) ⬇️
#python_tests 99.23% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
python/tskit/trees.py 98.66% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ec75f...5e90c6e. Read the comment docs.

@petrelharp
Copy link
Contributor Author

Oh, this PR actually closes #297.

@jeromekelleher
Copy link
Member

This is great, thanks @petrelharp. I'll start merging stuff in now (need to do a bit of rebasing first, so leave it with me).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants