-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LearningShapelets continuous integration test error on Linux #427
Fix LearningShapelets continuous integration test error on Linux #427
Conversation
I have added some print functions in the function |
This problem could be related to:
|
Hi, In https://www.tensorflow.org/api_docs/python/tf/keras/utils/set_random_seed EDIT: I'm just not sure in which version of TF it was introduced... |
Now both Linux and MacOs continuous integration tests are failing. |
For MacOs, the error message is the following: `tslearn/clustering/kshape.py::tslearn.clustering.kshape.KShape Terminating: Nested parallel kernel launch detected, the workqueue threading layer does not supported nested parallelism. Try the TBB threading layer. Current thread 0x0000700008f8d000 (most recent call first): Thread 0x0000700009010000 (most recent call first): |
For Linux, the error message is the following: =================================== FAILURES =================================== name = 'LearningShapelets'
tslearn/tests/test_estimators.py:215: tslearn/tests/test_estimators.py:197: in check_estimator X = array([[-0.84118762, -1.37894673, -1.88806533, ..., 1.1945725 , y estimator scale False pipeline learningshapelets inside pipeline estimator after fit pipeline after fit func_name classes_ [0 1] pipeline variables before func_pipeline ESTIMATOR AND PIPELINE ARE EQUAL BEFORE FUNC scale False ESTIMATOR AND PIPELINE ARE EQUAL BEFORE FUNC estimator variables after func pipeline variables after func_pipeline ESTIMATOR AND PIPELINE ARE EQUAL AFTER FUNC result result pipe ----------------------------- Captured stderr call ----------------------------- |
As expected, we obtain the exact same failing tests after "Empty commit". |
We obtain the exact same failing tests with or without |
With tensorflow==2.0, we obtain the following error message:
|
With tensorflow==2.8.0, some continuous integration tests are failing Linux, MacOS and Windows. |
The error message for Linux is the following: ==================================== ERRORS ==================================== ------------------------------- Captured stderr -------------------------------- ______________ ERROR collecting tslearn/tests/test_estimators.py _______________ ______________ ERROR collecting tslearn/tests/test_estimators.py _______________ ___________ ERROR collecting tslearn/tests/test_serialize_models.py ____________ ___________ ERROR collecting tslearn/tests/test_serialize_models.py ____________ -------- generated Nunit xml file: /home/vsts/work/1/s/test-output.xml --------- |
Using tensorflow==2.9.0 for Linux in azure-pipelines.yml, the tests pass for Linux and Windows. |
Codecov ReportBase: 94.60% // Head: 94.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 94.60% 94.67% +0.07%
==========================================
Files 59 62 +3
Lines 4538 4824 +286
==========================================
+ Hits 4293 4567 +274
- Misses 245 257 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Using tensorflow==2.10.0 for Linux in azure-pipelines.yml, the tests are failing on Linux and MacOS. |
There is the same failing tests for MacOS with and without using |
This PR is related to the following issue: #426 which is related to a test error in the continuous integration tests of the main branch.
This bug was first noticed in continuous integration tests of the PR #411 (which is now merged), but this bug seems unrelated to the PR.
The continuous integration tests are failing with Linux but they pass with Windows and MacOS.
I use Linux and Python 3.8, and the tests pass on my local computer.
The failing test is related to the test the class tslearn.shapelets.shapelets.LearningShapelets by functions:
test_all_estimators (tslearn/tests/test_estimators.py) --> check_estimator (tslearn/tests/test_estimators.py) --> check_pipeline_consistency (tslearn/tests/sklearn_patches.py).