Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readthedocs fail test changing build.image into build.os #487

Merged
merged 6 commits into from
Oct 16, 2023

Conversation

YannCabanes
Copy link
Contributor

@YannCabanes YannCabanes commented Oct 16, 2023

The readthedocs test is failing on the main branch with the following error message:
The configuration key "build.image" is deprecated. Use "build.os" instead to continue building your project. Read more at https://docs.readthedocs.io/en/stable/config-file/v2.html#build-os

Indeed, build.image is deprecated since Monday, October 16, 2023 and is now replaced by build.os:
https://blog.readthedocs.com/use-build-os-config/

Specific details to write the .readthedocs.yml file can be found at:
https://docs.readthedocs.io/en/stable/config-file/v2.html

@YannCabanes YannCabanes changed the title Fiux Fix readthedocs fail test changing build.image into build.os Oct 16, 2023
@YannCabanes
Copy link
Contributor Author

We have the following error related to the Ubuntu version:
Problem in your project's configuration. Invalid configuration option "build.os": expected one of (ubuntu-20.04, ubuntu-22.04), got ubuntu-latest

Here is a discussion about ubuntu-latest:
readthedocs/readthedocs.org#8861

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (37018ab) 93.32% compared to head (80a4cd9) 93.32%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   93.32%   93.32%           
=======================================
  Files          67       67           
  Lines        5725     5725           
=======================================
  Hits         5343     5343           
  Misses        382      382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YannCabanes YannCabanes merged commit 7a880ae into tslearn-team:main Oct 16, 2023
12 checks passed
@YannCabanes YannCabanes deleted the use-build-os branch December 21, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants