Align the gpc_error types more with the code #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 38.99% 38.99%
=======================================
Files 28 28
Lines 2090 2090
=======================================
Hits 815 815
Misses 1275 1275
Continue to review full report at Codecov.
|
tsloughter
reviewed
May 13, 2022
src/grpcbox_stream.erl
Outdated
| -type grpc_status() :: 0..16. | ||
| -type http_status() :: integer(). | ||
| -type grpc_error() :: {grpc_status(), grpc_status_message()}. | ||
| -type grpc_error() :: {binary(), % containing a grpc_status() value as text |
There was a problem hiding this comment.
Suggested change
| -type grpc_error() :: {binary(), % containing a grpc_status() value as text | |
| -type grpc_error() :: {unicode:unicode_binary(), % containing a grpc_status() value as text |
Assuming this will always be a utf8 binary string?
There was a problem hiding this comment.
Done (yes, I suppose it will, although I admit I haven't read enough http2 spec to know)
Add a type to specify what error values that the server side can handle from rpc method callback functions, since this is slightly different from the errors that can be returned on the client side.
tomas-abrahamsson
force-pushed
the
type-specs
branch
from
e94cf13 to
8f3448c
Compare
tsloughter
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a type,
grpc_callback_error()to specify what error values that the server side can handle from rpc method callback functions, since this is slightly different from the errors that can be returned on the client side: onlygrpc_errorandgrpc_extended_errorare handled, neither error nor http_error, see for instance here.If this is good—naming and all—then I can make a corresponding PR to the grpcbox_plugin template later.