Fix for ignored parameters = null (#36)

tspence · Oct 30, 2024 · f34497b · f34497b
1 parent 1cde483
commit f34497b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/src/SdkGenerator/Diff/PatchNotesGenerator.cs b/src/SdkGenerator/Diff/PatchNotesGenerator.cs
@@ -199,14 +199,14 @@ private static List<string> GetEndpointChanges(GeneratorContext context, Endpoin
             {
                 if (diff.Object2 is ParameterField p2 && diff.Object1 == null)
                 {
-                    if (context.Project.IgnoredParameters.All(ip => !string.Equals(ip.Name, p2.Name, StringComparison.OrdinalIgnoreCase)))
+                    if (context.Project.IgnoredParameters == null || context.Project.IgnoredParameters.All(ip => !string.Equals(ip.Name, p2.Name, StringComparison.OrdinalIgnoreCase)))
                     {
                         differences.Add($"{MakeApiName(item)} removed {p2.Location} parameter `{p2.Name}`");
                     }
                 }
                 else if (diff.Object1 is ParameterField p1 && diff.Object2 == null)
                 {
-                    if (context.Project.IgnoredParameters.All(ip => !string.Equals(ip.Name, p1.Name, StringComparison.OrdinalIgnoreCase)))
+                    if (context.Project.IgnoredParameters == null || context.Project.IgnoredParameters.All(ip => !string.Equals(ip.Name, p1.Name, StringComparison.OrdinalIgnoreCase)))
                     {
                         differences.Add($"{MakeApiName(item)} added {p1.Location} parameter `{p1.Name}`");
                     }

diff --git a/src/SdkGenerator/PatchNotes.md b/src/SdkGenerator/PatchNotes.md
@@ -1,3 +1,8 @@
+# 1.3.8
+October 20, 2024
+
+* Fixed issue where ignored parameters could be null
+
 # 1.3.7
 October 20, 2024
 

diff --git a/src/SdkGenerator/SdkGenerator.csproj b/src/SdkGenerator/SdkGenerator.csproj
@@ -12,14 +12,14 @@
     <PackageTags>SDK generator swagger openapi swashbuckle</PackageTags>
     <Copyright>Copyright 2021 - 2024</Copyright>
     <PackageReleaseNotes>
-      # 1.3.7
+      # 1.3.8
       October 20, 2024
 
-      * Fixed a minor typo that caused Typescript and Python-only build configs to fail
+      * Fixed an issue with ignored parameters
     </PackageReleaseNotes>
     <PackageIcon>docs/icons-puzzle.png</PackageIcon>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
-    <Version>1.3.7</Version>
+    <Version>1.3.8</Version>
     <Authors>Ted Spence</Authors>
     <!-- Project Url is filled in by sourcelink in the .NET 8 SDK, but you can add it explicitly via
     package -->