Allow bytes (non-json) message values #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 202f91c5a4ac0151f166a3f5716d89acc68b35b8)
(cherry picked from commit 04abd2195c21559c64102a8c774671dba9e03d79)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my use-case, message values are serialized protobuf messages which cannot be interpreted as JSON. As such, the line
message.value = str(message.value)was turning a serialized message likeb'test'into its string representation"b'test'". Upon consumption,json.dumps(message.value).encode()was further transforming the message, sending the bytes objectb'"b'test'"'to the consumer, and as such the consumer could not parse the intended protobuf message at all.This PR keeps the bytes object as-is if it couldn't be parsed as JSON. It only transforms it into its string representation in
to_dict()if necessary, since this seems to be only place where it needs a JSON-compatible type/value.