Fanout exchange #33
Merged
Fanout exchange #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, publishing a message to an exchange (either through the mock client, or through a "real" client connected to the mock server) would not result in that message being added to any queues bound to the exchange. Testing queues and exchanges were totally separate. E.g. for the same effect you would have to have a "real" client publish to an exchange, and have the mock client publish to an associated queue. This automatically adds any messages published to an exchange to any queues bound to that exchange (this assumes direct routing--fanout will be added in a follow-up).
declare_queue now actually does something, in terms of ensuring that the queue exists new queues are automatically bound to the default exchange
…f the same message with fanout exchanges
… message regardless of routing key
|
Hi @tsv1, |
|
Hi! Let's remove Python 3.7, as it's no longer supported by the PSF. |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 94.61% 94.32% -0.29%
==========================================
Files 14 14
Lines 594 617 +23
Branches 71 78 +7
==========================================
+ Hits 562 582 +20
- Misses 16 17 +1
- Partials 16 18 +2 ☔ View full report in Codecov by Sentry. |
|
@moyiz thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Great project.
In this PR I have rebased and fixed the changes that were introduced in these older ones:
#10
#23
I also changed
Storage._historyfrom{msg_id: msg}mapping to[(msg_id, msg), ...]list to better support multiple copies of messages by fanout exchanges since they have the same ID.Thanks.