Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the wheels include
tests
. (see attached log 1)This can cause problems with buildsystems like bazel.
Based on the configuration in setup.py I'm assuming this is unintended behavior.
This PR excludes them from the build. (see attached log 2)
log 1:
$ wget https://files.pythonhosted.org/packages/90/80/bebe9a4e68cf23aa4ae70bced2a36186a5fc74ff49 df4eaa70b9be163dc1/amqp_mock-0.6.1-py3-none-any.whl $ unzip -t amqp_mock-0.6.1-py3-none-any.whl | grep -e tests testing: tests/_test_utils/__init__.py OK testing: tests/_test_utils/amqp_client.py OK testing: tests/_test_utils/fixtures.py OK testing: tests/_test_utils/helpers.py OK testing: tests/_test_utils/schemas.py OK testing: tests/_test_utils/steps.py OK
log 2:
$ make build $ unzip -t dist/amqp_mock-0.6.1-py3-none-any.whl | grep -e tests