-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put OFirehose example in documentation to show how to subclass Feed class #113
Comments
Example custom feed for reading https://ofirehose.com/feed.json tsyesika/PyPump#113
I cant see the full conversation about this on pump.io, but i assume we're just talking about loading the https://ofirehose.com/feed.json file into a Feed object? I added a p firehose (why are you giggling?) command with code that could easily be added to PyPump instead |
That's a lot simpler than I was imagining - maybe we could add something similar to the documentation? (ha!) |
It's not a perfect solution as the ofirehose feed is more limited than the usual pump.io feeds and the class will have to be re-instantiated every time you want to get items from it, it could probably be improved by overriding a few more methods. |
We already have everything needed to read off OFirehose, but it would be nice to provide users with a something that they can just call and get Note objects etc. out of it.
The text was updated successfully, but these errors were encountered: