-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "endpoint" to something else #62
Comments
So what I propose for this is we don't have a generic term meaning url concerning this model but we have a specific descriptive variable e.g.
What do we think? yea or nay? |
All posted activities is sent through PumpObject._post_activity() which uses '/api/user/{username}/feed' relates to #62
Remove unused ENDPOINT property set object_type = 'collection' relates to #62
I have removed most endpoint properties as we don't actually use them internally and i don't see any reason why anyone else would use them. I think the question about descriptive uri variables is handled in referenced #66 so closing this one |
I find our usage of the word
endpoint
misleading.We are using it as a target for most of our activities which means it usually end up as something like
/api/user/{name}/feed/
no matter what object we are handlingThe pump.io API is using the word
endpoint
as a unique identifier for an object i.ehttp://<hostname>/api/<objectType>/<id>
The text was updated successfully, but these errors were encountered: