Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "endpoint" to something else #62

Closed
kabniel opened this issue Aug 25, 2013 · 2 comments
Closed

Rename "endpoint" to something else #62

kabniel opened this issue Aug 25, 2013 · 2 comments

Comments

@kabniel
Copy link
Collaborator

kabniel commented Aug 25, 2013

I find our usage of the word endpoint misleading.

We are using it as a target for most of our activities which means it usually end up as something like /api/user/{name}/feed/ no matter what object we are handling

The pump.io API is using the word endpoint as a unique identifier for an object i.e http://<hostname>/api/<objectType>/<id>

@tsyesika
Copy link
Owner

So what I propose for this is we don't have a generic term meaning url concerning this model but we have a specific descriptive variable e.g.

/api/user/{name}/profile could be called profile_uri
/api/{objectType}/{id} could be called object_uri

What do we think? yea or nay?

kabniel added a commit that referenced this issue Oct 3, 2014
All posted activities is sent through PumpObject._post_activity()
which uses '/api/user/{username}/feed'

relates to #62
kabniel added a commit that referenced this issue Oct 3, 2014
Remove unused ENDPOINT property
set object_type = 'collection'

relates to #62
@kabniel
Copy link
Collaborator Author

kabniel commented Oct 3, 2014

I have removed most endpoint properties as we don't actually use them internally and i don't see any reason why anyone else would use them.

I think the question about descriptive uri variables is handled in referenced #66 so closing this one

@kabniel kabniel closed this as completed Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants