Fix grading_data errors, when grading_data is not a dict

ttsirkia · Aug 20, 2018 · 802ca1a · 802ca1a
1 parent 0aef0dc
commit 802ca1a
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/exercise/templatetags/exercise.py b/exercise/templatetags/exercise.py
@@ -233,10 +233,9 @@ def get_grading_errors(submission):
     if grading_data.startswith('<pre>'):
         return grading_data[5:-6]
     try:
-        grading_data = json.loads(grading_data)
-    except (TypeError, ValueError):
+        return json.loads(grading_data).get('errors', "")
+    except (AttributeError, TypeError, ValueError):
         return ""
-    return grading_data.get('errors', "")
 
 
 @register.inclusion_tag("exercise/_text_stats.html", takes_context=True)