Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue that webview can't build. #37

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Fixed the issue that webview can't build. #37

merged 3 commits into from
Oct 31, 2024

Conversation

abc-JYL
Copy link
Contributor

@abc-JYL abc-JYL commented Oct 27, 2024

In the fix I use the mui's webview header, also replace the link.

@ttytm
Copy link
Owner

ttytm commented Oct 27, 2024

Thanks for making aware and putting work into this @abc-JYL !

To fix building with the latest known working webview version, we could pin the working ref instead. Currently, it points to master.

At:

const lib_url = 'https://raw.githubusercontent.com/webview/webview/master'

- const lib_url = 'https://raw.githubusercontent.com/webview/webview/master'
+ const lib_url = 'https://raw.githubusercontent.com/webview/webview/refs/tags/0.10.0'

This should be the only change required to make it work again.


I would prefer to keep the original upstream url as I don't see a reason to change it to a another repo which just copied the webview files from the upstream webview repo.

I think after this in a further separate change things can be updated work with the latest webview development state while keeping the original upstream.

@ttytm ttytm mentioned this pull request Oct 27, 2024
Copy link
Owner

@ttytm ttytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the mentioned changes.

The failing CI runs are related to v fmt having been updated since they last run, otherwise they are unrelated.

Thanks again for the efforts!

@ttytm ttytm merged commit 5ff0e4e into ttytm:main Oct 31, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants