Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow borrowed &str for MessageKey #5

Closed
wants to merge 2 commits into from
Closed

allow borrowed &str for MessageKey #5

wants to merge 2 commits into from

Conversation

asuper0
Copy link
Collaborator

@asuper0 asuper0 commented Sep 8, 2023

import hashbrown crate

@asuper0
allow borrowed &str for MessageKey
a0c495b 
import hashbrown crate
@asuper0 asuper0 temporarily deployed to cargo September 8, 2023 12:04 — with GitHub Actions Inactive
@tu6ge tu6ge temporarily deployed to cargo September 8, 2023 13:20 — with GitHub Actions Inactive
tu6ge
tu6ge reviewed Sep 8, 2023
View reviewed changes
Copy link
Owner

@tu6ge tu6ge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in validate method, names has third clone, the source cause of this problem is not here, but in the Rule trait, This issue should also be considered from a global perspective.

@tu6ge
Copy link
Owner

tu6ge commented Sep 12, 2023

Just now, I find a lib smartstring, It should be a new programme

@tu6ge tu6ge closed this in e55b9ff Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tu6ge tu6ge tu6ge left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asuper0 @tu6ge