Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: navigate user to correct pages #179

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

minhhang107
Copy link
Collaborator

Related issue

Fixes #164

Type of Change

  • Feat: Change which adds functionality/new feature
  • Fix: Change which fixes an issue
  • Refactor: Change which improves the structure of the code
  • Docs: Change which improves documentation

Description

  • Redirect to Edit page on signup (@hlavu I'm using a temp link for this, please update it in your Edit profile PR - line 109 Signup modal)
  • Redirect to Match page on signin
  • i icon on Match page should direct user to the Profile page of the target

Screenshot

N/A

Testing

Has this pull request been tested? Yes

Please describe shortly how you tested it: manual test

Note

The title of your PR should follow this format: [Type](area): Title

@vercel
Copy link

vercel bot commented Feb 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tuanthanh2067/seeksi/6hbJnkeeMxXvt71mtippq5TDQXPz
✅ Preview: https://seeksi-git-feature-164-add-navigation-to-pages-tuanthanh2067.vercel.app

Copy link
Owner

@tuanthanh2067 tuanthanh2067 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@oliver-pham oliver-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🍿 Feel free to merge

@minhhang107 minhhang107 merged commit a0269e7 into main Feb 22, 2022
@minhhang107 minhhang107 deleted the feature/164-add-navigation-to-pages branch February 22, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect user to correct page
3 participants