Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Switch to SWC #278

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feature: Switch to SWC #278

wants to merge 7 commits into from

Conversation

oliver-pham
Copy link
Collaborator

@oliver-pham oliver-pham commented Mar 8, 2022 •
edited
Loading

Related issue

Fixes #273

Type of Change

  • Feat: Change which adds functionality/new feature
  • Fix: Change which fixes an issue
  • Refactor: Change which improves the structure of the code
  • Docs: Change which improves documentation

Description

BREAKING CHANGE!
warning

This PR should replace the use of react-scripts with swc in compiling frontend code to speed up build time. I also configured swc to hot reload code on file changes.

Screenshot

  1. Compile time

Before
Screen Shot 2022-03-08 at 8 28 53 PM

After
Screen Shot 2022-03-08 at 7 20 29 PM

  1. Hot reload
Screen.Recording.2022-03-08.at.7.15.46.PM.mov

Testing

Some tests to consider:

  • All pages should function normally
  • Compile time should be reduced
  • Hot reloading should be working

Note

The title of your PR should follow this format: [Type](area): Title

@vercel
Copy link

vercel bot commented Mar 8, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tuanthanh2067/seeksi/A4hGWJ7QD9ARhYPfm6nU55F3jUcm
✅ Preview: https://seeksi-git-feature-273-switch-to-swc-tuanthanh2067.vercel.app

@oliver-pham oliver-pham force-pushed the feature/273-switch-to-swc branch from 37a1e18 to f85406e Compare March 9, 2022 21:51
tuanthanh2067
tuanthanh2067 reviewed Mar 24, 2022
View reviewed changes
Copy link
Owner

@tuanthanh2067 tuanthanh2067 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can resolve these conflicts and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuanthanh2067 tuanthanh2067 tuanthanh2067 left review comments

@minhhang107 minhhang107 Awaiting requested review from minhhang107

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to SWC
2 participants
@oliver-pham @tuanthanh2067