Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout getting changed to 60 seconds when set to 0 (unlimited) #31

Closed
wants to merge 1 commit into from

Conversation

mikeytown2
Copy link

When running from the command line the timeout is usually 0 (unlimited); looking at the code it doesn't take this into account and assumes that 60 is higher than 0 in this case.

When running from the command line the timeout is usually 0 (unlimited); looking at the code it doesn't take this into account and assumes that 60 is higher than 0 in this case.
@AntonEvers
Copy link
Contributor

@mikeytown2 your pull request has a bug: in the if ($name === 'max_execution_time' && $current > 0 && $current < $suggested) { you exclude 0 from being overwritten to 60. But in elseif ($current > -1 && ($suggested == -1 || $current < $suggested)) { the 0 value is changed to $suggested nonetheless. So your fix only treats -1 as unlimited effectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants