-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: keep order of commands, better docs #738
base: v3
Are you sure you want to change the base?
Conversation
Text: "start", | ||
Description: "Start the bot", | ||
}, { | ||
Text: "help", | ||
Description: "How to use the bot", | ||
}, { | ||
Text: "settings", | ||
Description: "{{ text `cmd_settings` }}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previous pr had a question about testing this part of template
#681 (comment)
The reasons to keep lt.Commands
in tests:
- make it clear what happens when you use templates with
lt.Commands()
- the test already contained testing of both Commands and CommandsLocale functions, kept it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@demget should I check anything else before you run CI workflow?
@dvordrova I meant the fact that |
@demget so you wouldn't |
Possible ways to resolve it I see
Which one do you prefer? |
Came across some difficulties when used layout, one of that is commands usage:
every restart I have different set of commands, owning to it is map (made it list)
not obvious to find way of templating commands (added to example.yml) and tests
not obvious how to use SetCommands for all not specified locales (added it in layout docstring)
Previous try #681