Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one in userspace metric writer #306

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix off-by-one in userspace metric writer #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/perf/counter/userspace/writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ bool Writer::handle(std::vector<UserspaceReadFormat>& data)

for (std::size_t i = 0; i < counter_buffer_.size(); i++)
{
values[i] = counter_buffer_[i] * counter_collection_.get_scale(i);
// In get_scale, index 0 is reserved for the metric leader, which we don't have in the
// userspace metric mode, so add 1 to the counter index
values[i] = counter_buffer_[i] * counter_collection_.get_scale(i + 1);
bmario marked this conversation as resolved.
Show resolved Hide resolved
}

writer_.write(metric_event_);
Expand Down
Loading