Revert "Turn EventDescription into class" #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead" This reverts commit c92ae69.
This reverts commit ebd23aa.
This reverts commit d7a079b.
This reverts commit 164ed96.
This reverts commit 170708d.
This reverts commit 78ec694.
…tional<EventGuard>" This reverts commit 524958d.
…read_file" This reverts commit 2630d74.
This reverts commit b3e6a11.
This reverts commit 18e4c0a.
This reverts commit 0167ea5.
This reverts commit ca4e337.
… create_event" This reverts commit 0d64daa.
This reverts commit cae0f19.
This reverts commit b134bbb.
This reverts commit a638d4b.
This reverts commit 1ac755e.
This reverts commit a7eed12.
This reverts commit 7fb053a.
This reverts commit c2c6940.
This reverts commit 28fbd3c.
This reverts commit e554a20.
This reverts commit 3ad6a74.
This reverts commit 18a400d.
This reverts commit 05299b9.
…Event factory" This reverts commit d73cc73.
This reverts commit fc32170.
This reverts commit c30368a.
|
Closed in favor of justing fixing the remaining issues as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #340
Sadly (mostly due to a lack of tests in lo2s) this PR breaks a lot of lo2s stuff, namely
--list-events, PFM support (#353 ) and system-monitoring mode (-A)