Skip to content

Commit

Permalink
Prevent LegacyKeyValueFormat warnings in Docker build
Browse files Browse the repository at this point in the history
The legacy "ENV key value" format is deprecated:
https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
  • Loading branch information
tueda committed Aug 14, 2024
1 parent b9c4b19 commit d20bb0c
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,19 @@ RUN apt-get update && \


#### Define working folders
ENV PROJECT_FOLDER "/madminer"
ENV SOFTWARE_FOLDER "/madminer/software"
ENV PROJECT_FOLDER="/madminer"
ENV SOFTWARE_FOLDER="/madminer/software"


#### MadGraph 5 environment variables
ENV MG_VERSION "MG5_aMC_v2.9.16"
ENV MG_FOLDER "MG5_aMC_v2_9_16"
ENV MG_FOLDER_PATH "${SOFTWARE_FOLDER}/${MG_FOLDER}"
ENV MG_BINARY_PATH "${SOFTWARE_FOLDER}/${MG_FOLDER}/bin/mg5_aMC"
ENV MG_VERSION="MG5_aMC_v2.9.16"
ENV MG_FOLDER="MG5_aMC_v2_9_16"
ENV MG_FOLDER_PATH="${SOFTWARE_FOLDER}/${MG_FOLDER}"
ENV MG_BINARY_PATH="${SOFTWARE_FOLDER}/${MG_FOLDER}/bin/mg5_aMC"

#### CERN ROOT environment variables
ENV PATH $PATH:$ROOTSYS/bin
ENV LD_LIBRARY_PATH $LD_LIBRARY_PATH:$ROOTSYS/lib
ENV PATH=$PATH:$ROOTSYS/bin
ENV LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$ROOTSYS/lib

Check warning on line 49 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Variables should be defined before their use

UndefinedVar: Usage of undefined variable '$LD_LIBRARY_PATH' More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 49 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Variables should be defined before their use

UndefinedVar: Usage of undefined variable '$LD_LIBRARY_PATH' More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/


### Install MadGraph 5 Python dependencies
Expand All @@ -69,7 +69,7 @@ RUN echo "set auto_convert_model T" | python3 ${MG_BINARY_PATH}
RUN echo "import model EWdim6-full" | python3 ${MG_BINARY_PATH}

# Delphes environment variables
ENV ROOT_INCLUDE_PATH "${ROOT_INCLUDE_PATH}:${MG_FOLDER_PATH}/Delphes/external"
ENV ROOT_INCLUDE_PATH="${ROOT_INCLUDE_PATH}:${MG_FOLDER_PATH}/Delphes/external"

Check warning on line 72 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Variables should be defined before their use

UndefinedVar: Usage of undefined variable '$ROOT_INCLUDE_PATH' More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 72 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Variables should be defined before their use

UndefinedVar: Usage of undefined variable '$ROOT_INCLUDE_PATH' More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/


#### Copy files
Expand Down

0 comments on commit d20bb0c

Please sign in to comment.