Fix issue with not closed file descriptor #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berejant
commented
Nov 15, 2023
Comment on lines
+353
to
+358
| func (p *Parser) Close() (err error) { | ||
| if p.file != nil { | ||
| err = p.file.Close() | ||
| } | ||
| return err | ||
| } |
There was a problem hiding this comment.
provide interface to Close parser (for case when Parse was not closed; useful to use like
defer parser.Close())
| FilePath: p.lexer.file, //TODO: set filepath here, | ||
| Block: p.parseBlock(), | ||
| } | ||
| _ = p.Close() |
There was a problem hiding this comment.
Buffer was read at this point, so it's time to close file.
|
Thanks for the contribution @berejant! |
tufanbarisyildirim
merged commit 5dd06bb
into
tufanbarisyildirim:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28