Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle relative symbolic links #98

Merged
merged 10 commits into from
Jan 9, 2025
Merged

Conversation

KaiOelfke
Copy link
Contributor

This should fix tuist/tuist#7145. There may be other or better ways to fix this. But the root issue seems to be handling of an relative symbolic link.

Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix! Two minor comments, after which we can merge 🙂

Sources/FileSystem/FileSystem.swift Show resolved Hide resolved
Sources/FileSystem/FileSystem.swift Outdated Show resolved Hide resolved
@fortmarek fortmarek changed the title Add test and fix handling of relative symbolic links fix: handling of relative symbolic links Dec 20, 2024
@fortmarek fortmarek changed the title fix: handling of relative symbolic links feat: handle relative symbolic links Dec 20, 2024
@KaiOelfke KaiOelfke requested a review from fortmarek December 20, 2024 10:56
@KaiOelfke
Copy link
Contributor Author

Thanks a lot for the fix! Two minor comments, after which we can merge 🙂

I made these changes. You can have another look.

Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again 👏

@fortmarek fortmarek merged commit c60a236 into tuist:main Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants