Fix issue that it is not possible to remove a remote package #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for xcodeproj ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
luispadron
reviewed
Nov 13, 2023
luispadron
approved these changes
Nov 13, 2023
|
A bit shame that this PR did not make it into 8.16.0 release 😢 |
|
I dont have ability to merge. @pepicrft, @danyf90 @fortmarek could one of you take a look? |
kwridan
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Thanks for fixing this @kevin-kp
small note, to correctly remove a package, there's a few other objects and references that need to be removed (not just from packageReferences, see https://github.com/tuist/XcodeProj/blob/main/Sources/XcodeProj/Objects/Project/PBXProject.swift#L207)
|
@kwridan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #802
Implementation 👩💻👨💻
It checks that only the references are kept that are not part of the current type.
This is done by getting the object of the reference and checking the type of this reference.