-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add On Demand Resources Support #6178
Conversation
Sources/TuistGenerator/Generator/ProjectDescriptorGenerator.swift
Outdated
Show resolved
Hide resolved
d2d59e6
to
fc91295
Compare
e284daa
to
740d10e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kapitoshka438 for the detailed investigation into this!
6bad49f
to
f2767e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @kapitoshka438
Sources/TuistGenerator/Generator/ProjectDescriptorGenerator.swift
Outdated
Show resolved
Hide resolved
f2767e3
to
ac98bc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the updates @kapitoshka438
@all-contributors add @kapitoshka438 for code |
I've put up a pull request to add @kapitoshka438! 🎉 |
87d6b47
to
8040c7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things. Thanks a lot for putting the work here.
@kapitoshka438 would you mind adding a README.md where you document the fixture that you added? After adding it the README will automatically surface in the documentation website and it'll be useful for Tuist users to see some examples. |
6875c5b
to
6d314c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work 👏
Short description 📝
On-demand resources are app contents that are hosted on the App Store and are separate from the related app bundle that you download.
The resources can be of any type supported by bundles except for executable code. Supported on-demand resource types are described in Apple Developer Documentation.
Developers identify on-demand resources during development by assigning them one or more tags. A tag is a string identifier they create.
It's important for us to understand how are tags defined in generated
pbxproj
.Tags assigned to resource files or folders are defined in targets
PBXBuildFile
section:Tags assigned to assets in Asset Catalogs are not presented in pbxproj and defined in their
Contents.json
:All tags assigned to any type of on-demand resources are listed in
PBXProject
section in alphabet order:On targets level, each tag is assigned to one of the categories below:
Initial install tags and Prefetched order tags are defined in the targets
XCBuildConfiguration
section:The last category is default, not described in pbxproj and represents all tags from
KnownAssetTags
excluding tags from the first two categories.This pull request add support for on-demand resources.
Contents.json
in Asset Catalogs to generate KnownAssetTags (defining tags for file resources was already implemented).Target
init has got additional parameters to define Initial Install Tags and Prefetch Order TagsHow to test the changes locally 🧐
This PR adds new fixture:
ios_app_with_on_demand_resources
, with acceptance, generation, edit and lint tests.Contributor checklist ✅
mise run lint:fix
Reviewer checklist ✅
changelog:added
,changelog:fixed
, orchangelog:changed
, and the title is usable as a changelog entry