Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive reference and guide #89

Closed
wants to merge 11 commits into from
Closed

Conversation

masiedu4
Copy link

Brief

  • Update README file

Activities

  • This PR sets to provide documentation for the deroll project and its router and wallet functionalities

Copy link

changeset-bot bot commented May 31, 2024

⚠️ No Changeset found

Latest commit: d61712c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Author

@masiedu4 masiedu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuler review requested

Copy link
Owner

@tuler tuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I think most of the changes should be part of the documentation generated from typescript code.

I didn't have time to setup that generation yet.

README.md Outdated

### 2. Create notices, vouchers and reports

#### `createNotice(request: { payload: 0x${string}; }): Promise<number>`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a method of the App interface.
For a reference manual I'd rather have something generated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @tuler I pushed some changes

For the auto-generation, are we looking at something like TypeDoc? need some elaborate feedback there. thanks!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding documentation generation I'd experiment three alternatives:

https://jsdoc.app
https://typedoc.org
https://tsdoc.org

@tuler
Copy link
Owner

tuler commented Jun 10, 2024

I configured typedoc myself, using the monorepo guidelines described at https://typedoc.org/api/#md:monorepos--workspaces. I even tried the upcoming beta version, which improves support for monorepos, among other things.

Documentation is generated ok, but I don't like the result very much.
I'll try next week to follow another strategy, which is using VitePress for a docs website, and generating markdown from JSDoc into a VitePress website.

If that doesn't work well either, I'll reevaluate the options.

@tuler
Copy link
Owner

tuler commented Oct 3, 2024

Documentation already published at https://deroll.dev

@tuler tuler closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants