Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke test release candidate #406

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Smoke test release candidate #406

merged 1 commit into from
Jan 8, 2024

Conversation

klippx
Copy link
Collaborator

@klippx klippx commented Dec 21, 2023

Problem

Fixes #408

Solution

This PR smoke tests a release to ensure the npm artefact is ready for release. The steps are roughly:

  1. Clone repo, install deps
  2. Prepare a mappersmith release
  3. Clone https://github.com/klippx/mappersmith-consumer repo
  4. In mappersmith-consumer: Link to the release candidate
  5. In mappersmith-consumer: Run all test scripts verifying that they run with release candidate

Impact

  • This ensures that consumer projects are not broken*
  • If there is a missed case it is easy to add to that as a new workspace consumer project
  • No impact on this project in terms of deps

*) to the extent that we know about it and that it is documented, of course

Copy link

changeset-bot bot commented Dec 21, 2023

⚠️ No Changeset found

Latest commit: bd9ff52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@klippx klippx force-pushed the release/smoke-test branch 9 times, most recently from ce41fce to 9ed3bdd Compare December 21, 2023 15:14
@klippx klippx marked this pull request as ready for review December 21, 2023 15:22
@klippx klippx self-assigned this Dec 21, 2023
@klippx klippx merged commit f2a1adf into master Jan 8, 2024
10 checks passed
@klippx klippx deleted the release/smoke-test branch January 8, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smoke test new release candidate
1 participant