Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OplogToRedis: Better Logging for Denylist Failures #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alex-goodisman
Copy link
Contributor

Summary

When the denylist fails to update due to a database error, the error is now logged.

Jira Task

  • No ticket needed (check only if level of impact is No-op)

Level of Impact

Please select exactly one option. To change the level of impact, first unselect the current level of impact and then select the new level of impact.

  • 1 - High
  • 2 - Medium
  • 3 - Low
  • 4 - No-op

Impact Analysis

This is a logging only change, and it's not an error level log.

Release Notes

none

Release Change Category

Please select exactly one option. To change the release change category, first unselect the current category and then select the new one.

  • 1 - Internal Only (Non Customer Facing)
  • 2 - Bug Fix (Customer Facing)
  • 3 - New Feature
  • 4 - Feature Enhancement
  • 5 - Feature Deprecated
  • 6 - Release Change Category Not Needed

Feature Flags

none

Test Plan

n/a

Checklist

Check each when they are done or confirmed to not apply. If something here isn't checked, this isn't ready to be merged. Seriously. You are making your colleagues lives a lot easier by doing this consistently. Be a good Tulipian.

For more information on the requirements for every pull request, see Development Definition of Done.

Copy link
Contributor

@eparker-tulip eparker-tulip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- logging proved to show what was needed. Nothing more should be needed here in OTR apart from bumping the minor version in the default.nix file (make it 3.8.5 since I have an open PR with 3.8.4 already)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants