ui: use ColorDefault where appropriate #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This indeed makes things much more usable! Thanks! |
tulir
approved these changes
Aug 2, 2021
|
The username colours are also not great. I'll just leave this screenshot here. At least in my case, switching to using a dark background for the terminal is not an option, as I have rather severe astigmatism, making it very difficult to read light on dark.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not the configurable colors change as was requested in issue #23 but at least it makes gomuks usable with black on white terminal color schemes, and should not impact white on black looks significantly.
There's at least still an issue with /help box's title as boxes in mauview don't have ForegroundColor property.