Added notify_openbsd.go to the notification library so that notifications will be available on OpenBSD systems as well #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions will be available on OpenBSD systems as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use
gomukson a laptop running OpenBSD withnotify-send, but I noticed that the SendNotification function was using thelib/notification/notify_unsupported.golibrary instead of thelib/notification/notify_linux.golibrary, which should work fine for OpenBSD, minus the reliance onpaplay, which is not available in base on OpenBSD.I created
lib/notification/notify_openbsd.gousingnotify_linux.goas a template. It's the same thing, essentially, minus any notification sounds since OpenBSD has no way to play .ogg files in base and I don't want to create extra dependencies.