List unread rooms on no query in quick room selector #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps to easily go through and view all the unread rooms.
meain
commented
Jun 26, 2022
| if len(room.UnreadMessages) > 0 { | ||
| if room.UnreadCount() > 0 { | ||
| // Higher importance to rooms where notifications are not disabled | ||
| fs.matches = append( |
There was a problem hiding this comment.
I am not entirely sure if this is the best approach. Let me know if I should maybe switch out the the type of fs.matches to something else.
|
@tulir, I tested this PR as I worked on something similar, seems solid. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to easily go through and view all the unread rooms.