Fix mangled newlines in some code blocks #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just found out this change kind of breaks the "plain text" mode (^L). I'm investigating this right now. |
|
I added a third patch to preserve the whitespace characters at the beginning and end of the codeblocks. I am not sure if it could cause other problems, but it seems to be sensible and I didn't have any issue with my limited testing. It does not affect the plaintext mode though. This is mostly important for indentation when the first line does not start from the first column: Before f213755
After f213755
EDIT: This third patch seems to introduce a crash sometimes. |
Because some tokens can contain newlines and not only comment tokens, I removed the comments specific code to handle newlines in a more generic way.
n-peugnet
force-pushed
the
mangled-lines
branch
from
f213755
to
1cff17a
Compare
|
As I just had a crash with the third commit. I removed it from this pull request (and rebased it by the way) to be able to merge it faster. |
tulir
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because some tokens can contain newlines and not only comment tokens, I removed the comments specific code to handle newlines in a more generic way.
Before
After
Before
After
Fixes #274
Fixes #213