Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Clean-up: Move include of SimpleIni.h form ETISS.h to ETISS.cpp #128

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

CFoik
Copy link

@CFoik CFoik commented Feb 17, 2023

Moving include of external dependency header SimpleIni form ETISS.h to ETISS.cpp where it is actually required.
This allows external programs to use ETISS.h without re-importing SimpleIni.

@github-actions
Copy link

github-actions bot commented Feb 17, 2023

Performance Statistics

Status for the gcc Just-In-Time Engine (for commit 653e2ab): No significant performance change
Current dhrystone MIPS for gcc JIT : 96.7
Previous best for gcc JIT (recorded in commit 4d2d26f): 108.31, difference -10.72%

Status for the llvm Just-In-Time Engine (for commit 653e2ab): Regressed since commit 78716e7
Current dhrystone MIPS for llvm JIT : 25.99
Previous best for llvm JIT (recorded in commit 940dbdd): 36.11, difference -28.03%

Status for the tcc Just-In-Time Engine (for commit 653e2ab): 🥇 New best performance!
Current dhrystone MIPS for tcc JIT : 58.33
Previous best for tcc JIT (recorded in commit 653e2ab): 58.33, difference 0.08%

This comment was created automatically, please do not change!

@JoGei
Copy link
Member

JoGei commented Feb 23, 2023

Good intention and way forward in cleaning up sources.

Problem is that headers are cluttered with includes that are not needed in the including header.

Some additions that I made:

I have introduced SimpleIni as a CMake object library target (no linking of simpleini.a) with public headers that will be installed alongside etiss headers.

@rafzi rafzi mentioned this pull request Feb 23, 2023
@rafzi rafzi merged commit b1f9cf0 into master Feb 23, 2023
@JoGei JoGei deleted the SimpleIni_fix branch August 9, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants