-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to allow building ETISS Plugins out-of tree #150
base: master
Are you sure you want to change the base?
Conversation
e47f28d
to
98a7ea2
Compare
Rebased on master |
After the latest commit, building etiss plugins can be done without making any changes to the cmakefiles of the plugin: Just |
… INCLUDE_DIRECTORIES
CI passed, any comments @wysiwyng ? |
Looks good from a code standpoint, please add documentation. Currently it is not obvious how the plugins can be used in ETISS after they were built. Overall, additional work needs to be put in to make ETISS actually relocatable. |
Before, etiss would just print a warning due to passing a nullptr to addPlugin: ``` === Setting up plug-ins === ETISS: Info: Adding Plugin QVanillaAcceleratorT2 ETISS: Warning: etiss::CPUCore::addPlugin() called without passing a valid plugin pointer. { {core0} } ```
@wysiwyng I am working on the docs now. Should it be part of the (quite outdated) Docygen documentation or can I just write a markdown file for explaining how to integrate out-of-tree plugins? |
@wysiwyng I have just pushed three more commits that are related to Plugins and would like to hear your feedback:
|
I realized that there are quite some inconsistencies regarding default values of INI settings. Can I look into fixing these in a followup PR? Also there are a lot of places where file paths are build manually using string concatenation. IMHO it would be good to use boost FS everwhere instead, what do you think @wysiwyng? |
@wysiwyng Here is the documentation I came up with: https://github.com/tum-ei-eda/etiss-accelerator-plugins/blob/main/README.md It's currently specific for the |
The latter should be good enough for now. |
Docs for how to build plugins out-of-tree will follow.
(QVanillaAccelerator
depends on https://github.com/tum-ei-eda/etiss/commits/patch_sysplugs_vanilla/ which was never merged to main).