Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-Email not sent when emails are deactivated #224

Open
dostuffthatmatters opened this issue Jun 10, 2024 · 0 comments
Open

Test-Email not sent when emails are deactivated #224

dostuffthatmatters opened this issue Jun 10, 2024 · 0 comments
Assignees
@dostuffthatmatters
Labels
status:implemented has been implemented in some dev branch tiny not a lot to do
Milestone
4.2.0

Comments

@dostuffthatmatters
Copy link
Member

Test emails should always be sent no matter the configuration. Solved by removing the following two lines:

https://github.com/tum-esm/pyra/blob/main/packages/core/utils/exception_email_client.py#L184-L185
@dostuffthatmatters dostuffthatmatters added backlog not included in a planned update yet tiny not a lot to do labels Jun 10, 2024
@dostuffthatmatters dostuffthatmatters changed the title Test Email not sent when emails are deactivated Test-Email not sent when emails are deactivated Jun 10, 2024
@dostuffthatmatters dostuffthatmatters added status:planned is assigned to a specific milestone and removed backlog not included in a planned update yet labels Aug 16, 2024
@dostuffthatmatters dostuffthatmatters added this to the 4.1.4 milestone Aug 16, 2024
@dostuffthatmatters dostuffthatmatters modified the milestones: 4.1.4, 4.2.0 Oct 9, 2024
@dostuffthatmatters dostuffthatmatters added status:implemented has been implemented in some dev branch and removed status:planned is assigned to a specific milestone labels Oct 9, 2024
dostuffthatmatters added a commit that referenced this issue Oct 9, 2024
@dostuffthatmatters
Close #224
b76ebdb
@dostuffthatmatters dostuffthatmatters self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dostuffthatmatters dostuffthatmatters

Labels
status:implemented has been implemented in some dev branch tiny not a lot to do
Projects
None yet
Milestone
4.2.0
Development

No branches or pull requests
1 participant
@dostuffthatmatters