Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.8 - Bug Fixes #153

Merged
merged 19 commits into from
May 3, 2023
Merged

4.0.8 - Bug Fixes #153

merged 19 commits into from
May 3, 2023

Conversation

@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for pyra-4-documentation canceled.

Name Link
🔨 Latest commit dbd7a1a
🔍 Latest deploy log https://app.netlify.com/sites/pyra-4-documentation/deploys/63efa153f5a7d80008215c4b

@dostuffthatmatters
Copy link
Member Author

@patrickjaigner Python needs an exact version (3.10 is not valid, but 3.10.6 is). However, we don't know which Python version existing users have installed (the docs don't specify a minor release: https://pyra.esm.ei.tum.de/docs/user-guide/setup#python-310). Therefore, I added the 3.10.* only for the Python version. But Python itself definitely keeps their semantic versioning straight.

Copy link
Contributor

@patrickjaigner patrickjaigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dostuffthatmatters dostuffthatmatters added this to the 4.0.8 - Bug Fixes milestone Feb 17, 2023
@dostuffthatmatters dostuffthatmatters changed the title v4.0.8 4.0.8 Feb 17, 2023
@dostuffthatmatters dostuffthatmatters changed the title 4.0.8 4.0.8 - Bug Fixes Feb 17, 2023
@dostuffthatmatters dostuffthatmatters changed the base branch from main to integration-4.0.8 February 17, 2023 17:51
This was referenced Mar 28, 2023
@dostuffthatmatters dostuffthatmatters changed the base branch from integration-4.0.8 to main April 4, 2023 16:53
@dostuffthatmatters dostuffthatmatters changed the base branch from main to integration-4.0.8 April 4, 2023 16:53
@dostuffthatmatters
Copy link
Member Author

dostuffthatmatters commented Apr 4, 2023

I rebased this branch to the latest main branch (extended documentation). That is why I force-pushed it. Also, I needed to change base for the PR to recognize that it is only 3 commits ahead.

@dostuffthatmatters dostuffthatmatters added the status:in-progress is being work on in some dev branch label May 2, 2023
improve astronomy class
improve the way of passing the config to the astronomy class
use skyfield instead of astropy
add astronomical dataset to repository
remove astropy dependency
test astronomy class
debug mypy things, close #154
Copy link
Contributor

@patrickjaigner patrickjaigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding #155 I'm not too fond of this change. It doesn't address the core issue and force closes all currently running OPUS instances. It also introduces a new method of closing OPUS in addition to the already existing one.
There is an easier solution for it.

@dostuffthatmatters
Copy link
Member Author

Regarding #155 I'm not too fond of this change. It doesn't address the core issue and force closes all currently running OPUS instances. It also introduces a new method of closing OPUS in addition to the already existing one. There is an easier solution for it.

Sure, then I will comment out the changes from #155, and we can do that in a later release, once we know how to fix this elegantly.

@dostuffthatmatters dostuffthatmatters merged commit 07fbd94 into integration-4.0.8 May 3, 2023
@dostuffthatmatters dostuffthatmatters deleted the development-moritz branch May 3, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:camtracker status:in-progress is being work on in some dev branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants