-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0.8 - Bug Fixes #153
4.0.8 - Bug Fixes #153
Conversation
✅ Deploy Preview for pyra-4-documentation canceled.
|
@patrickjaigner Python needs an exact version (3.10 is not valid, but 3.10.6 is). However, we don't know which Python version existing users have installed (the docs don't specify a minor release: https://pyra.esm.ei.tum.de/docs/user-guide/setup#python-310). Therefore, I added the 3.10.* only for the Python version. But Python itself definitely keeps their semantic versioning straight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
dbd7a1a
to
9cb740a
Compare
I rebased this branch to the latest main branch (extended documentation). That is why I force-pushed it. Also, I needed to change base for the PR to recognize that it is only 3 commits ahead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding #155 I'm not too fond of this change. It doesn't address the core issue and force closes all currently running OPUS instances. It also introduces a new method of closing OPUS in addition to the already existing one.
There is an easier solution for it.
Sure, then I will comment out the changes from #155, and we can do that in a later release, once we know how to fix this elegantly. |
98d1780
to
07fbd94
Compare
4.0.7
tum-esm-utils
more #165