Adding Label based predicates #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor to make this make a bit more sense maybe removing small jawn refactoring and trying to fix test cases fixing tests improving tests tweaks moving more tests into yaml configs better tests dont cache test results updating tests to make matching predicate on labels work adding docs
byxorna
force-pushed
the
gabe/label-predicates
branch
from
647990b to
ddd7144
Compare
alex-laties
approved these changes
Jul 10, 2019
| @@ -63,10 +64,10 @@ test-race: ARGS=-race ## Run tests with race detector | |||
| $(TEST_TARGETS): NAME=$(MAKECMDGOALS:test-%=%) | |||
| $(TEST_TARGETS): test | |||
| check test tests: fmt lint vendor | ; $(info $(M) running $(NAME:%=% )tests…) @ ## Run tests | |||
| $Q $(GO) test -timeout $(TIMEOUT)s $(ARGS) $(TESTPKGS) | |||
| $Q $(GO) test -count=1 -timeout $(TIMEOUT)s $(ARGS) $(TESTPKGS) | |||
There was a problem hiding this comment.
might be worth noting why you're disabling test caching here. I think it's a good idea but most won't understand what -count=1 is doing here.
There was a problem hiding this comment.
Pushing test configuration into yaml files means when the test config changes, go isnt smart enough to know to invalidate the cache :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large refactor to clean things up before opensourcing, and adds a new feature: Docker label based selectors! If you use
LABEL foo=barin yourDockerfile, you can use alabel:rule to filter all Manifests that have that label set present and apply an action to them in bulk.