Fix: Merge env and volumeMounts with initContainers #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
changed the title
byxorna
approved these changes
Mar 29, 2019
|
Hey there, is this PR missing something? |
|
Hey @iwilltry42, sorry about the delay merging. I was hoping to get some more eyes on this, but no, this PR isnt missing anything. I'll merge now and cut a release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Looks like I forgot this in my last PR. In my eyes, the injected
initContainersshould also receive the injectedenvvars andvolumeMounts.Testing Steps
Nothing changed here. I already tested it in our dev and prod environments.
Reviewers
Required reviewers: @byxorna, @komapa, @defect
Request reviews from other people you want to review this PR in the "Reviewers" section on the right.