Add Aspect Ratio setting to resize + crop media #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches what the user sees displayed.
The display rect of the media is not relevant for scaleToFill media since it will fill the provided space.
4 tasks
bjtitus
commented
Apr 8, 2021
| @@ -133,6 +137,11 @@ final class EditorView: UIView, MovableViewCanvasDelegate, MediaPlayerViewDelega | |||
|
|
|||
| weak var playerView: MediaPlayerView? | |||
|
|
|||
| var exportSize: CGSize { | |||
There was a problem hiding this comment.
Exports media to the same size we are displaying to the user.
# Conflicts: # Classes/Editor/EditorView.swift
danielebogo
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WordPress PR: wordpress-mobile/WordPress-iOS#16229
CameraSettings.aspectRatiovalueCameraSettings.aspectRatiovalue.