Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a crash when recording & multitasking #109

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Fixes a crash when recording & multitasking #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Classes/Recording/VideoOutputHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ final class VideoOutputHandler: NSObject, VideoOutputHandlerProtocol {
private var audioInput: AVAssetWriterInput?
private var recordedVideoFrameFirst: Bool = false
private var videoQueue: DispatchQueue = DispatchQueue(label: VideoHandlerConstants.queue)
private let stopRecordingSemaphore = DispatchSemaphore(value: 0)

// MARK: - external methods

Expand Down Expand Up @@ -83,15 +82,16 @@ final class VideoOutputHandler: NSObject, VideoOutputHandlerProtocol {
else if let pixelBuffer = currentVideoPixelBuffer, let presentationTime = currentPresentationTime {
processVideoPixelBuffer(pixelBuffer, presentationTime: presentationTime)
}

stopRecordingSemaphore.signal()
}

/// Stops recording video and exports as a mp4
///
/// - Parameter completion: success boolean if asset writer completed
func stopRecordingVideo(completion: @escaping (Bool) -> Void) {
stopRecordingSemaphore.wait()
guard recording else {
completion(false)
return
}
recording = false

if let sampleBuffer = currentVideoSampleBuffer {
Expand Down