-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve memory pressure while exporting GIFs #115
Conversation
I used the iPhone 8 Plus (iOS 14.4) simulator to test this but I am having this assertion failure after these steps:
|
Another thing, Tumblr was not depending on the main branch, not sure about the most up to date state but you may need to target another branch. |
You need to activate the Metal options on the initial screen.
…On 1 Jun 2021, 12:02 +0100, Pinar Olguc ***@***.***>, wrote:
Another thing, Tumblr was not depending on the main branch, not sure about the most up to date state but you may need to target another branch.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@SergioEstevao Pinar is right. You have to merge this first and then cherry pick this commit in a new PR targeting a base branch created from 1.0.3 tag, also bumping the version to 1.0.4 for CanvasKamera. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I can confirm that the the crash doesn't happen anymore.
Even though I think autoreleasepool is not the most ideal solution it is prolly the most time efficient one currently so LGTM. 👍
(Don't forget to update the target branch.)
@pinarol I think this can be merged on main. We can cherry pick the commit on a new base so the fix will be there even when we will update to the most recent Kanvas |
Ok then 👍 |
This PR updates the exporting loops for creating GIF to be wrapped with autorelease blocks so the memory pressure is smaller when exporting then.
Related bug: https://jira.tumblr.net/browse/PROD-15147
How to test: