Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter type change from Tumblr app #127

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Add filter type change from Tumblr app #127

merged 1 commit into from
Jan 4, 2022

Conversation

bjtitus
Copy link
Collaborator

@bjtitus bjtitus commented Jan 4, 2022 •
edited
Loading

This sets the filter type used when exporting video. I think there was a bad merge somewhere and this got dropped from the file.

Testing

  • Select a video from the photo library
  • Apply a filter to that video
  • Ensure that the filter is applied

@bjtitus bjtitus force-pushed the exporter-filter-type branch from 187f75f to a686823 Compare January 4, 2022 18:52
adriana-elizondo
adriana-elizondo approved these changes Jan 4, 2022
View reviewed changes
Copy link
Collaborator

@adriana-elizondo adriana-elizondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works perfectly! 🎉

@bjtitus bjtitus deleted the branch main January 4, 2022 20:33
@bjtitus bjtitus closed this Jan 4, 2022
@bjtitus bjtitus reopened this Jan 4, 2022
@bjtitus bjtitus changed the base branch from editor-view-delegate to main January 4, 2022 20:37
@bjtitus bjtitus merged commit 00cc97f into main Jan 4, 2022
@bjtitus bjtitus deleted the exporter-filter-type branch January 4, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriana-elizondo adriana-elizondo adriana-elizondo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjtitus @adriana-elizondo