Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stories bug fixes for 16.8 release #93

Merged
merged 4 commits into from
Mar 2, 2021
Merged

Stories bug fixes for 16.8 release #93

merged 4 commits into from
Mar 2, 2021

Conversation

bjtitus
Copy link
Collaborator

@bjtitus bjtitus commented Mar 1, 2021 •
edited
Loading

Related WordPress PR: wordpress-mobile/WordPress-iOS#15996

  • Appends all added segments to the end of existing segments.
  • Adds the iPhone 12 Pro to the belongsToIPhoneXGroup. This should be removed in the future to rely on the safeAreaLayoutGuide so it's not necessary to keep updating with changing screen sizes.
Before After

Testing

Appending Segments

  • Open the editor
  • Select media from your library
  • Tap the + icon in the lower right to add more media
  • Select multiple items
  • Ensure that all items are appended to the set of frames

iPhone 12 Pro

  • Open the Editor on iPhone 12 Pro (simulator works fine)
  • Select media from your library
  • Ensure that the frames are in a portrait aspect ratio and are not squished as seen above.

@bjtitus
Fix media clips view on iPhone 12 Pro
0f30936 
All of this logic needs to change but will require some large refactoring so I am adding this case for now.
@bjtitus
Append all new segments when inserting
6f70e5e 
The logic here was previously trying to insert at the selected point but I think this is fine.
@bjtitus bjtitus self-assigned this Mar 1, 2021
@bjtitus bjtitus mentioned this pull request Mar 2, 2021
Merged
3 tasks
@bjtitus bjtitus marked this pull request as ready for review March 2, 2021 16:15
@bjtitus bjtitus requested a review from aerych March 2, 2021 18:56
aerych
aerych approved these changes Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@aerych aerych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @bjtitus!
Tested with the related WPiOS PR.
Code looks good to me and I've confirmed I select multiple items and add them at once.
:shipit: !

@bjtitus bjtitus merged commit f4d5428 into main Mar 2, 2021
@bjtitus bjtitus deleted the stories/16-8-fixes branch March 2, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerych aerych aerych approved these changes

Assignees

@bjtitus bjtitus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjtitus @aerych