-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build man page as part of workflows #149
Conversation
Happy to change anything (especially dedup once you're otherwise happy, if the repetition offends). You can see recent workflows: Note: there are a fair number of warnings, but I don't think my changes made them qualitatively worse. Probably an extra "The Also, release 2.0.5 was created from those builds. Oh, one quite disappointing thing (for me) is that the man page generation is VERY slow. Mostly in staging the environment. An asciidoctor docker image exists that on my local machine gave much faster results (once I pulled the imager the first time; don't know if that'd be an issue for the GitHub Actions runner), if the (lack of) speed is a concern. The output was nearly the same as that for the existing build process, and could probably be closer with minor massaging of the |
@@ -1,5 +1,5 @@ | |||
:man source: git-absorb | |||
:man version: 0.5.0 | |||
:man version: {man-version} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't figure out how to supply a value directly from the command line, so aliased the attribute
dd139f9
to
b3fe640
Compare
Okay, that's all I have. If the changes can better fit your vision, do let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me. the flag should be an easy speedup, but otherwise i don't care too much about how long it takes to run in ci
.github/workflows/build.yml
Outdated
- name: Setup environment | ||
run: | | ||
sudo apt-get update | ||
sudo apt-get --assume-yes install asciidoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add --no-install-recommends
? probably part of the reason it's slow is it's installing texlive, which has tons of heavy binary assets in it (eg fonts)
Rebasing to resolve conflicts (and make viewing subsequent diffs easier). |
44d2ef6
to
1f41c62
Compare
I opted to incorporate the change instead of ** OMG that was fast! build-man-page beat any of the test runs! I didn't even have time to finish taht comment about the fixups I was making and will continue now! ** pushing the fixup and squashing later, since it's so simple and you can see it in the Compare link anyhow. |
1f41c62
to
cbc8c52
Compare
Whoops. Forgot release.yml. Fixed. |
Fixes #74.
Closes #149. (Which it includes.)