Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shell] Keep the shell folder clean #61

Merged
merged 1 commit into from
Jun 20, 2023
Merged

[shell] Keep the shell folder clean #61

merged 1 commit into from
Jun 20, 2023

Conversation

thesilentline
Copy link
Contributor

Closes: #47

What is the purpose of the change

Did create a new data folder under shell
also did move all .txt files to data folder
Finally update related scripts that use these txt files to use the new location shell/data/.txt

@tungbq tungbq self-requested a review June 20, 2023 00:18
@tungbq tungbq changed the title fixed error #47 [shell] Keep the shell folder clean Jun 20, 2023
@tungbq tungbq merged commit 49746d4 into tungbq:main Jun 20, 2023
@tungbq
Copy link
Owner

tungbq commented Jun 20, 2023

LGTM! Thanks @thesilentline

@tungbq
Copy link
Owner

tungbq commented Jun 20, 2023

@all-contributors add @thesilentline as code

@allcontributors allcontributors bot mentioned this pull request Jun 20, 2023
Merged
@allcontributors
Copy link
Contributor

@tungbq

I've put up a pull request to add @thesilentline! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tungbq tungbq Awaiting requested review from tungbq tungbq is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[shell] Keep the shell folder clean
2 participants
@thesilentline @tungbq