Skip to content

Create shell-check.yml - reviewdog #4

Create shell-check.yml - reviewdog

Create shell-check.yml - reviewdog #4

GitHub Actions / shellcheck succeeded Aug 18, 2023 in 0s

reviewdog [shellcheck] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (7)

topics/k8s/k8s-helloworld-cleanup.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
topics/k8s/k8s-helloworld-cleanup.sh|5 col 1| kill_port references arguments, but none are ever passed.
topics/k8s/k8s-helloworld-cleanup.sh|6 col 3| port_fwd appears unused. Verify use (or export if used externally).
topics/k8s/k8s-helloworld-cleanup.sh|8 col 18| Consider using pgrep instead of grepping ps output.
topics/k8s/k8s-helloworld-cleanup.sh|12 col 11| Double quote to prevent globbing and word splitting.
topics/k8s/k8s-helloworld-cleanup.sh|16 col 1| Use kill_port "$@" if function's $1 should mean script's $1.
topics/shell/basic.sh|33 col 1| read without -r will mangle backslashes.