Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced DropDownComboBox with MRUComboBox #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CoderGimmic
Copy link

To add to this issue #7, I made a fork CoderGimmic@b588ec9 and replaced the existing ComboBox with a MRUComboBox. It's the first time I'm writing code to extend Visual Studio so there's probably something I've missed. I'll gladly fix any things done wrong given some pointers as I'd really like this feature to be implemented, or feel free to use my commit as a basis to implement the feature yourself instead.

Currently I've just replaced the existing ComboBox with a MRUComboBox using the following example code as base https://github.com/Microsoft/VSSDK-Extensibility-Samples/blob/master/Combo_Box/C%23/VsPkg.cs#L320. So Instead of having multiple events tied to the regular dropdown I've replaced them with a single event which handles read and writes using your backend to get the command line arguments.

According to the example provided above: "The list of choices entered is automatically remembered by the IDE on a per-user/per-machine basis." when using a MRU ComboBox. So as of now I've just disabled the SettingsStore which you've implemented.

This tool is invaluable to me as I'm often switching between command arguments, thanks!

~Gimmic

@sharwell
Copy link
Member

@CoderGimmic Just so you are aware, after submitting this pull request a build was triggered, and the output of the build is available if you following the link it added to AppVeyor. The VSIX was attached to the Artifacts tab there so you can install the update immediately if you want.

@CoderGimmic
Copy link
Author

@sharwell Good to know, thanks!

@b0g2
Copy link

b0g2 commented Jul 10, 2018

I just noticed this pull request. It works perfectly, thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants