Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider definite assignment assertions #495

Open
15 of 25 tasks
sharwell opened this issue Jan 1, 2021 · 0 comments
Open
15 of 25 tasks

Reconsider definite assignment assertions #495

sharwell opened this issue Jan 1, 2021 · 0 comments
Labels
enhancement ts-flavor

Comments

@sharwell
Copy link
Member

sharwell commented Jan 1, 2021 •
edited
Loading

The following assertions were added in #496 to existing problematic code as part of enabling the strict compilation option. Some of these may be able to be rewritten to avoid the need to use assertions.

  • TestPerformance.ts
    • totalTransitions
    • computedTransitions
    • decision
    • _sllConfigs
  • ATN.ts
    • ruleToStartState
    • ruleToStopState
    • ruleToTokenType
    • lexerActions
  • BlockEndState.ts
    • startState
  • BlockStartState.ts
    • endState
  • LoopEndState.ts
    • loopBackState
  • PlusBlockStartState.ts
    • loopBackState
  • RuleStartState.ts
    • endState
  • StarLoopEntryState.ts
    • loopBackState
  • InterpreterDataReader.ts
    • atn
    • vocabulary
    • ruleNames
    • channels
    • modes
  • Parser.ts
    • _input
    • _ctx
  • ParserInterpreter.ts
    • _rootContext
  • ParserRuleContext.ts
    • _start
  • Recognizer.ts
    • _interp
  • TokenStreamRewriter.ts
    • instructionIndex
sharwell added a commit to sharwell/antlr4ts that referenced this issue Jan 1, 2021
@sharwell
Enable 'strict' compilation
dace7c3 
Remaining problems are suppressed using definite assignment assertions.

See tunnelvisionlabs#495
@sharwell sharwell mentioned this issue Jan 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ts-flavor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sharwell