Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to TypeScript 2.1 #255

Merged
merged 1 commit into from
Dec 29, 2016
Merged

Conversation

sharwell
Copy link
Member

This fixes the compilation error caused by the use of Object.freeze by updating the code to use ReadonlyMap instead of just Map.

⚠️ This pull request is an alternative to #254, should we decide that updating to TypeScript 2.1+ is acceptable.

This fixes the compilation error caused by the use of Object.freeze by
updating the code to use ReadonlyMap instead of just Map.
Copy link
Contributor

@mike-lischke mike-lischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly care about compatibility with Visual Studio Code. I'm totally fine with 2.1 if it works there (currently vscode uses 2.1.4). Using the latest version if possible is generally a good idea anyway.

@sharwell sharwell self-assigned this Dec 29, 2016
@sharwell sharwell merged commit 49ed006 into tunnelvisionlabs:master Dec 29, 2016
@sharwell sharwell deleted the typescript-2.1 branch December 29, 2016 14:49
@sharwell sharwell added fixed and removed blocker labels Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants